Horton

Re: docs: outdated reference to recursive expression evaluation

John Naylor <jcnaylor@gmail.com>

View thread View on postgr.es
From: John Naylor <jcnaylor@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2018-12-10T14:55:11Z
Lists: pgsql-hackers

Attachments

On 12/8/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> John Naylor <jcnaylor@gmail.com> writes:
>> In confg.sgml, in the section about max_stack_depth, there's this
>> sentence:
>> "The safety margin is needed because the stack depth is not checked in
>> every routine in the server, but only in key potentially-recursive
>> routines such as expression evaluation."
>
>> Since the change in expression evaluation in v10, there's probably a
>> better example of recursive routines, but I'm not sure what that would
>> be.
>
> We could say "expression compilation" and it'd still be valid.  Or just
> drop the last four words altogether.  I don't think we want to expend the
> verbiage to be more precise here, since it's only a tangential point.

I'm inclined to agree. If you like, here's a patch to leave out the example.

-John Naylor

Commits

  1. Add stack depth checks to key recursive functions in backend/nodes/*.c.

  2. Doc: remove obsolete reference to recursive expression evaluation.