Horton

Re: master fails to build on Windows

John Naylor <jcnaylor@gmail.com>

View thread View on postgr.es
From: John Naylor <jcnaylor@gmail.com>
To: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Date: 2018-05-18T11:49:15Z
Lists: pgsql-hackers

Attachments

On 5/18/18, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:
> Hi
>
> I was building the sources I got from https://www.postgresql.org/
> ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
> like "*Cannot
> open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
> 'catalog/pg_tablespace_d.h'" . *I've attached the log.

I'm thinking the include/catalog/pg_*_d.h headers got dist-cleaned
when creating the snapshot, and the build script doesn't know to copy
them over. If you're able to test, does the attached patch fix the
issue? (This may not be the right permanent fix, but hopefully it will
confirm my suspicion)

-John Naylor

Commits

  1. MSVC builds must use a separate stamp file for copying generated headers.

  2. Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.