Horton

Re: Possible integer overflow in bringetbitmap()

James Hunter <james.hunter.pg@gmail.com>

View thread View on postgr.es
From: James Hunter <james.hunter.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Evgeniy Gorbanyov <gorbanyoves@basealt.ru>, pgsql-hackers@lists.postgresql.org
Date: 2025-01-10T19:22:37Z
Lists: pgsql-hackers

Attachments

On Fri, Dec 20, 2024 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Dec 10, 2024 at 12:33:08PM +0900, Michael Paquier wrote:
> > Sure, you could do (a) and (b) together.  It also seems to me that it
> > is just simpler to make totalpages a int64 to map automatically with
> > the result expected by the caller of bringetbitmap(), and we know that
> > based on MaxBlockNumber we'll never run out of bits.
>
> That should be simple enough.  Are you planning to send a proposal of
> patch?

Attached the proposed one-line fix.
James

Commits

  1. Fix potential integer overflow in bringetbitmap()