Horton

Re: [PATCH] Clean up property graph error messages

Ayush Tiwari <ayushtiwari.slg01@gmail.com>

View thread
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2026-05-07T09:04:05Z
Lists: pgsql-hackers 
Hi,


On Thu, 7 May 2026 at 14:15, Peter Eisentraut <peter@eisentraut.org> wrote:

>
> > and moves a
> > ReleaseSysCache() call before an ERROR ereport in
> > check_element_properties().
> >
> > The existing code should be cleaned up by
> > the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> > placed after ereport(ERROR) was unreachable.
>
> I think that's fine.  I don't think the change makes this better.
>

IIUC that is dead code right now, it never reaches that point to release?

Regards,
Ayush