Re: [PATCH] Fix column name escaping in postgres_fdw stats import
Ayush Tiwari <ayushtiwari.slg01@gmail.com>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Alex Guo <guo.alex.hengchen@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, efujita@postgresql.org
Date: 2026-05-12T08:02:44Z
Lists: pgsql-hackers
Hi Fujita-san, On Tue, 12 May 2026 at 13:06, Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > Hi Ayush, > > On Mon, May 4, 2026 at 7:24 AM Ayush Tiwari <ayushtiwari.slg01@gmail.com> > wrote: > > Are there some edits you would like me to make on the patch? > > One thing I noticed is the test case you added; it only tests > departing column names with single quotes, but it's better to also > test that with backslashes, to confirm the patch addresses the issue > in [1] as well. So I updated the patch as such. New version > attached. Other than that the patch looks good to me, so I'll push it > if no objections from you (or anyone else). > > Thanks for the updated version, and for folding in the backslash case from [1]. I confirmed that the patch applies cleanly on master and that make -C contrib/postgres_fdw check passes, including the new dtest_ftable case. The merged test seems a strict improvement. No objections from me. Regards, Ayush