[PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION
Ayush Tiwari <ayushtiwari.slg01@gmail.com>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Date: 2026-04-21T04:34:11Z
Lists: pgsql-hackers
Attachments
- 0001-Fix-duplicate-errmsg-in-ALTER-TABLE-SPLIT-PARTITION.patch (application/octet-stream) patch 0001
Hi hackers,
The ereport() in transformPartitionCmdForSplit() that fires when
splitting a non-default partition while a default partition already
exists has two errmsg() calls:
ereport(ERROR,
errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
errmsg("can not split non-DEFAULT partition \"%s\"", ...),
errmsg("new partition cannot be DEFAULT because ..."),
parser_errposition(...));
The second one should had been errdetail()
The attached patch changes the second errmsg() to errdetail().
Also, I think "can not" can be replaced with "cannot" for consistency
throughout? Havent added is as part of this patch though. Thoughts?
Regards,
Ayush
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Rationalize error comments in partition split/merge tests
- ecb2508aaf9b 19 (unreleased) landed
-
Message corrections for partition split/merge commands
- 52e629be95fc 19 (unreleased) landed