Horton

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

Robert Treat <rob@xzilla.net>

View thread View on postgr.es
From: Robert Treat <rob@xzilla.net>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>, Nathan Bossart <nathandbossart@gmail.com>, jian he <jian.universality@gmail.com>, Masahiro Ikeda <ikedamsh@oss.nttdata.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-05-01T15:04:10Z
Lists: pgsql-hackers 
On Thu, May 1, 2025 at 3:22 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> On 30.04.25 17:17, Robert Treat wrote:
> > But otherwise this LGTM.
>
> Thanks, I have worked this into the commit.  I wanted to get away from
> phrases like "needs to be rebuilt" or "must be rebuilt" because that
> possibly sounds like you have to do it manually.  So I tweaked it a bit
> further, but I think I captured the essence.
>

Yeah, that was my thinking as well; commit looks good.

> I'm closing the open item.
>

Thanks Peter.

Robert Treat
https://xzilla.net

Commits

  1. doc: Improve explanations when a table rewrite is needed

  2. doc: Explain more thoroughly when a table rewrite is needed

  3. Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.