Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

Jaime Casanova <jaime@2ndquadrant.com>

View thread

From: Jaime Casanova <jaime@2ndquadrant.com>

To: Magnus Hagander <magnus@hagander.net>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-01-15T21:00:26Z

Lists: pgsql-hackers

Attachments

basebackup_nfields.patch (text/x-patch) patch

On Wed, Jan 11, 2012 at 5:11 PM, Magnus Hagander <magnus@hagander.net> wrote:
>
> No, no reason. Adding such a check would be a good idea.
>

ok. patch attached, it also adds a few PQclear() calls before
disconnect_and_exit().
btw, in BaseBackup() in line 1149 (after the patch is applied) there
is an exit instead of disconnect_and_exit() and that is probably a
typo too

-- 
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación