Re: Measuring relation free space
Jaime Casanova <jaime@2ndquadrant.com>
From: Jaime Casanova <jaime@2ndquadrant.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Greg Smith <greg@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-11-08T21:12:25Z
Lists: pgsql-hackers
Attachments
- relation_free_space-v3.patch (text/x-patch) patch v3
On Sun, Nov 6, 2011 at 5:38 AM, Magnus Hagander <magnus@hagander.net> wrote: > > Looks pretty useful. > thanks for the review, attached is a new version of it > One quick stylistic comment - we don't generally use "* 1.0" to turn > an int into a double - just use a cast. > ok > > Hooking into a ring buffer seems like an almost requirement before you > can run this on a larger production system, wouldn't it? I don't know > how hard that is code-wise, but it certainly seems worthwhile. > seems it wasn't too difficult... i just have to indicate the right buffer access strategy so it's using a ring buffer now -- Jaime Casanova www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capacitación