Horton

Re: pg_stat_database deadlock counter

Jaime Casanova <jaime@2ndquadrant.com>

View thread
From: Jaime Casanova <jaime@2ndquadrant.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-01-22T18:35:19Z
Lists: pgsql-hackers 
On Mon, Jan 16, 2012 at 3:19 PM, Magnus Hagander <magnus@hagander.net> wrote:
> Attached patch adds a counter for number of deadlocks in a database to
> pg_stat_database.
>

A little review:

- it applies with a few hunks
- the oid you have chosen for the function pg_stat_get_db_deadlocks()
is already in use, please choose another one using the unused_oids
script (3150)
- pg_stat_reset() doesn't reset deadlock counter (see
pgstat_recv_resetcounter())


everything else seems fine to me

-- 
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación