Re: Review of pg_archivecleanup -x option patch
Jaime Casanova <jaime@2ndquadrant.com>
From: Jaime Casanova <jaime@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Smith <greg@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-03-09T05:46:42Z
Lists: pgsql-hackers
On Thu, Mar 8, 2012 at 8:25 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Sun, Feb 12, 2012 at 9:19 PM, Greg Smith <greg@2ndquadrant.com> wrote: >> The smaller step of automatically stripping the specified suffix from the >> input file name, when it matches the one we've told the program to expect, >> seems like a usability improvement unlikely to lead to bad things though. >> I've certainly made the mistake you've shown when using the patched version >> of the program myself, just didn't think about catching and correcting it >> myself before. We can rev this to add that feature and resubmit easily >> enough, will turn that around soon. > > This change seems plenty small enough to slip in even at this late > date, but I guess we're lacking a new version of the patch. > Sorry, here's the patch rebased and with the suggestion from Alex. Which reminds me, I never thank him for the review (shame on me) :D -- Jaime Casanova www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capacitación