Re: Partitioned tables and covering indexes
Jaime Casanova <jaime.casanova@2ndquadrant.com>
From: Jaime Casanova <jaime.casanova@2ndquadrant.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>,
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-10T20:49:11Z
Lists: pgsql-hackers
On 10 April 2018 at 10:36, Teodor Sigaev <teodor@sigaev.ru> wrote: >> Does the attached fix look correct? Haven't checked the fix with >> ATTACH >> PARTITION though. >> >> >> Attached patch seems to fix the problem. However, I would rather get >> rid of modifying stmt->indexParams. That seems to be more logical >> for me. Also, it would be good to check some covering indexes on >> partitioned tables. See the attached patch. > > Seems right way, do not modify incoming object and do not copy rather large > and deep nested structure as suggested by Amit. > > But it will be better to have a ATTACH PARTITION test too. > the patch worked for me, i also tried some combinations using ATTACH PARTITION and found no problems -- Jaime Casanova www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix interference between covering indexes and partitioned tables
- 524054598fd3 11.0 landed
-
Cleanup covering infrastructure
- c266ed31a8a3 11.0 landed
-
Rename IndexInfo.ii_KeyAttrNumbers array
- c9c875a28fa6 11.0 landed