Horton
Menu

Re: Define DatumGetInt8 function.

Aleksander Alekseev <aleksander@tigerdata.com>

View thread
From: Aleksander Alekseev <aleksander@tigerdata.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Kirill Reshke <reshkekirill@gmail.com>, David Rowley <dgrowleyml@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2026-01-06T14:21:55Z
Lists: pgsql-hackers 
Hi,

> > Kirill, are you working on this patch?
>
> Yes, PFA.
>
>  > I've not studied in detail,
> > but looks like it would require making
> > char_decrement()/char_increment() and btcharskipsupport() all use
> > CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
> > rather than 0/UCHAR_MAX.
>
> This is also a possible change, and can be a separate patch. I will
> try to also work on this this week.

v1 looks incomplete to me. As I understand, Tom proposed to get rid of
UInt8 conversions as well. Are you going to implement this idea as
well?

-- 
Best regards,
Aleksander Alekseev

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust some incorrect *GetDatum() macros

  2. Remove Int8GetDatum function