Horton

Thread

Commits

  1. Remove obsolete RECHECK keyword completely

  2. Remove pg_dump/pg_dumpall support for dumping from pre-9.2 servers.

  1. Remove obsolete RECHECK keyword completely

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-02T10:41:06Z

    I propose to remove the obsolete RECHECK keyword completely.  This used 
to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it 
has done nothing (except issue a NOTICE) since PostgreSQL 8.4.  Commit 
30e7c175b81 removed support for dumping from pre-9.2 servers, so this no 
longer serves any need, it seems to me.

This now removes it completely, and you'd get a normal parse error if 
you used it.

  2. Re: Remove obsolete RECHECK keyword completely

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-08-02T13:55:50Z

    Peter Eisentraut <peter@eisentraut.org> writes:
> I propose to remove the obsolete RECHECK keyword completely.  This used 
> to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it 
> has done nothing (except issue a NOTICE) since PostgreSQL 8.4.  Commit 
> 30e7c175b81 removed support for dumping from pre-9.2 servers, so this no 
> longer serves any need, it seems to me.

+1 for the idea; didn't vet the patch closely.

			regards, tom lane

  3. Re: Remove obsolete RECHECK keyword completely

    Aleksander Alekseev <aleksander@timescale.com> — 2024-08-05T13:44:28Z

    Hi,

> I propose to remove the obsolete RECHECK keyword completely.  This used
> to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
> has done nothing (except issue a NOTICE) since PostgreSQL 8.4.  Commit
> 30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
> longer serves any need, it seems to me.
>
> This now removes it completely, and you'd get a normal parse error if
> you used it.

I reviewed and tested the code. LGTM.

--
Best regards,
Aleksander Alekseev

  4. Re: Remove obsolete RECHECK keyword completely

    Peter Eisentraut <peter@eisentraut.org> — 2024-08-09T05:27:53Z

    On 05.08.24 15:44, Aleksander Alekseev wrote:
>> I propose to remove the obsolete RECHECK keyword completely.  This used
>> to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
>> has done nothing (except issue a NOTICE) since PostgreSQL 8.4.  Commit
>> 30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
>> longer serves any need, it seems to me.
>>
>> This now removes it completely, and you'd get a normal parse error if
>> you used it.
> 
> I reviewed and tested the code. LGTM.

committed, thanks