Re: Table AM modifications to accept column projection lists

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Cc: Jacob Champion <pchampion@vmware.com>, "zyu@yugabyte.com" <zyu@yugabyte.com>, "pryzby@telsasoft.com" <pryzby@telsasoft.com>, "hlinnaka@iki.fi" <hlinnaka@iki.fi>, "sawada.mshk@gmail.com" <sawada.mshk@gmail.com>, "soumyadeep2007@gmail.com" <soumyadeep2007@gmail.com>, "Ashwin Agrawal (Pivotal)" <aagrawal@pivotal.io>, "melanieplageman@gmail.com" <melanieplageman@gmail.com>

Date: 2021-06-01T12:38:33Z

Lists: pgsql-hackers

Attachments

wip.patch (application/octet-stream) patch

Hi Soumyadeep, Jacob,

> Thanks for the review!

I came across this patch and noticed that it rotted a little, especially
after removing inheritance_planner() in 86dc9005. I managed to resolve the
conflicts on current `master` (eb89cb43), see the attached patch. The code
compiles but doesn't pass the tests. I'm currently in the process of
reviewing it and didn't figure out what the issue is yet. Just wanted to
let you know. I also believe changing the patch status to "Waiting on
Author" would be appropriate.

-- 
Best regards,
Aleksander Alekseev