Re: Fortify float4 and float8 regression tests by ordering test results

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Cc: Pavel Borisov <pashkin.elfe@gmail.com>

Date: 2025-04-22T14:13:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid depending on post-UPDATE row order in float4/float8 tests.
- da83b1ea10c2 18.0 landed

Hi Pavel,

> It's not a big problem, but propose a simple fix for the tests. It
> just adds ORDER BY 1 to all relevant float4 and floa8 queries.

Thanks for the patch. That's a good change IMO.

> I don't
> have a strong opinion about backpatching this, but as the patch
> changes only regression tests, it's maybe also worth backpatching.

I don't see a reason for backpatching this but I'm not strongly
opposed to the idea either.

-- 
Best regards,
Aleksander Alekseev