Horton

Re: Refactor UnpinBuffer()

Aleksander Alekseev <aleksander@timescale.com>

View thread View on postgr.es
From: Aleksander Alekseev <aleksander@timescale.com>
To: PostgreSQL Development <pgsql-hackers@postgresql.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Zhang Mingli <zmlpostgres@gmail.com>
Date: 2022-09-29T08:22:24Z
Lists: pgsql-hackers 
Nathan, Zhang,

Thanks for the review!

> Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
> call to GetPrivateRefCountEntry()? From my quick skim of the code, it
> seems like it should be safe, but I thought I'd ask the question.
>
> Same question, have a look, it doesn’t seem to matter.

Yep, I had some doubts here as well but it seems to be safe.

-- 
Best regards,
Aleksander Alekseev

Commits

  1. Remove useless argument from UnpinBuffer()

  2. Fix various shortcomings of the new PrivateRefCount infrastructure.