Re: CREATE TABLE ( .. STORAGE ..)

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Teodor Sigaev <teodor@sigaev.ru>, Matthias van de Meent <boekewurm+postgres@gmail.com>, wenjing zeng <wjzeng2012@gmail.com>

Date: 2022-06-15T14:51:06Z

Lists: pgsql-hackers

Attachments

v3-0001-CREATE-TABLE-.-STORAGE.patch (application/octet-stream) patch v3-0001
v3-0002-Handle-SET-STORAGE-and-SET-COMPRESSION-similarly.patch (application/octet-stream) patch v3-0002

Hi hackers,

I noticed that cfbot is not entirely happy with the patch, so I rebased it.

> I see that COMPRESSION and STORAGE now are handled slightly
> differently in the grammar. Maybe we could standardize that a bit
> more; so that we have only one `STORAGE [kind]` definition in the
> grammar?
>
> As I'm new to the grammar files; would you know the difference between
> `name` and `ColId`, and why you would change from one to the other in
> ALTER COLUMN STORAGE?

Good point, Matthias. I addressed this in 0002. Does it look better now?

-- 
Best regards,
Aleksander Alekseev

Commits

Allow specifying STORAGE attribute for a new table
- 784cedda0604 16.0 landed