Re: Add connection active, idle time to pg_stat_activity

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Cc: Sergey Dudoladov <sergey.dudoladov@gmail.com>, torikoshia <torikoshia@oss.nttdata.com>, Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Rafia Sabih <rafia.pghackers@gmail.com>

Date: 2022-07-22T09:42:20Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unstable pg_amcheck tests.
- cd3f429d9565 15.0 cited

Hi hackers,

All in all the patch seems to be in good shape.

> This is consistent with the current documentation:
>
> > Each individual server process transmits new statistical counts to the collector just before going idle; so a query or transaction still in progress does not affect the displayed totals.
>
> But it makes me wonder if there will be a lot of use of total_idle_in_transaction_time and if the patch should actually alter this behavior.
>
> Thoughts?

On second thought, this is arguably out of scope of this particular
patch and this particular discussion. In any case, having some stats
is better than none.

I'm going to change the status of the patch to "Ready for Committer"
in a short time unless anyone has a second opinion.

-- 
Best regards,
Aleksander Alekseev