Re: Catalog domain not-null constraints

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Peter Eisentraut <peter@eisentraut.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, jian he <jian.universality@gmail.com>, vignesh C <vignesh21@gmail.com>

Date: 2024-03-18T10:02:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix ALTER DOMAIN NOT NULL syntax
- 9895b35cb88e 17.0 landed
Catalog domain not-null constraints
- e5da0fe3c22b 17.0 landed
Add tests for domain-related information schema views
- 9578393bc513 17.0 landed

Hi,

> Anyway, in order to move this forward, here is an updated patch where
> the ADD CONSTRAINT ... NOT NULL behavior for domains matches the
> idempotent behavior of tables.  This uses the patch that Jian He posted.

I tested the patch on Raspberry Pi 5 and Intel MacBook and also
experimented with it. Everything seems to work properly.

Personally I believe new functions such as
validateDomainNotNullConstraint() and findDomainNotNullConstraint()
could use a few lines of comments (accepts..., returns..., etc). Also
I think that the commit message should explicitly say that supporting
NOT VALID constraints is out of scope of this patch.

Except for named nitpicks v4 LGTM.

-- 
Best regards,
Aleksander Alekseev