Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Cc: Bruce Momjian <bruce@momjian.us>, Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Michael Paquier <michael@paquier.xyz>

Date: 2025-06-20T14:01:41Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent: improve formatting of multiline comments.
- 60f9467c3834 19 (unreleased) landed
Adjust style of some debugging macros.
- ba1e14134a77 19 (unreleased) landed
Fix a couple of comments.
- 123661427b97 19 (unreleased) landed
Add IGNORE NULLS/RESPECT NULLS option to Window functions.
- 25a30bbd4235 19 (unreleased) cited
Split WaitEventSet functions to separate source file
- 393e0d231405 18.0 cited

Attachments

v3-0001-pgindent-improve-formatting-of-multiline-comments.patch (application/octet-stream) patch v3-0001

Hi,

> Given the quality of BSD indent code, I have _always_ found it easier to
> modify pgindent.  ;-

:D Initially I thought that the problem was simple enough to solve it
in C, but this turned out not to be true.

> It's going to be simpler to modify pgindent then. PFA the updated patch.

I noticed a mistake in v2. Here is the corrected patch. Changes
comparing to the previous version:

```
-    $lines[-1] =~ s!/(.+)\*/!/$1\n \*/!;
+    $lines[-1] =~ s!(.+) \*/!$1\n \*/!;
```

-- 
Best regards,
Aleksander Alekseev