Horton

Re: A minor adjustment to get_cheapest_path_for_pathkeys

Aleksander Alekseev <aleksander@timescale.com>

View thread View on postgr.es
From: Aleksander Alekseev <aleksander@timescale.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Richard Guo <guofenglinux@gmail.com>
Date: 2023-09-05T16:01:09Z
Lists: pgsql-hackers 
Hi Robert,

> I don't think that's the correct conclusion. You said here that you
> didn't think the patch was valuable. Then you said the same thing over
> there. You agreeing with yourself is not a consensus.

The word "consensus" was a poor choice for sure. The fact that I
suggested to reject the patch and nobody objected straight away is not
a consensus.

> I think this patch is a good idea and should be committed.

No problem, changing status back to "Needs review".

-- 
Best regards,
Aleksander Alekseev

Commits

  1. Reorder tests in get_cheapest_path_for_pathkeys().

  2. Fix an assortment of improper usages of string functions