Re: pgsql: psql: add an optional execution-count limit to \watch.
Aleksander Alekseev <aleksander@timescale.com>
From: Aleksander Alekseev <aleksander@timescale.com>
To: pgsql-committers@lists.postgresql.org
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>
Date: 2023-04-10T12:48:57Z
Lists: pgsql-hackers
Attachments
- fix.diff (application/octet-stream) patch
Hi, > I wonder if we can setup as least some buildfarm members to exercise > TAP tests on non-C locales. > > > > The proposed fix is attached. > > > > LGTM, will push in a bit (unless you want to?) > > Please push. The test still fails under the following conditions: ``` $ env | grep UTF-8 LC_ADDRESS=ru_RU.UTF-8 LC_NAME=ru_RU.UTF-8 LC_MONETARY=ru_RU.UTF-8 LC_PAPER=ru_RU.UTF-8 LANG=en_US.UTF-8 LC_IDENTIFICATION=ru_RU.UTF-8 LC_TELEPHONE=ru_RU.UTF-8 LC_MEASUREMENT=ru_RU.UTF-8 LC_CTYPE=en_US.UTF-8 LC_TIME=ru_RU.UTF-8 LC_ALL=en_US.UTF-8 LC_NUMERIC=ru_RU.UTF-8 ``` This is up-to-dated Ubuntu 22.04 with pretty much default settings except for the timezone changed to MSK and enabled Russian keyboard layout. Here is a proposed fix. I realize this is a somewhat suboptimal solution, but it makes the test pass regardless of the locale settings. -- Best regards, Aleksander Alekseev
Commits
-
Fix Utils.pm's locale-munging so that Perl itself is also affected.
- b124104e73c0 16.0 landed
-
Fix locale-dependent test case.
- cd82e5c79d14 16.0 landed
-
psql: add an optional execution-count limit to \watch.
- 00beecfe839c 16.0 cited