Re: CREATE TABLE ( .. STORAGE ..)
Aleksander Alekseev <aleksander@timescale.com>
From: Aleksander Alekseev <aleksander@timescale.com>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
Teodor Sigaev <teodor@sigaev.ru>, wenjing zeng <wjzeng2012@gmail.com>
Date: 2022-06-16T13:40:55Z
Lists: pgsql-hackers
Hi Matthias, > Apart from this comment on the format of the patch, the result seems solid. Many thanks. > When updating a patchset generally we try to keep the patches > self-contained, and update patches as opposed to adding incremental > patches to the set. My reasoning was to separate my changes from the ones originally proposed by Teodor. After doing `git am` locally a reviewer can see them separately, or together with `git diff origin/master`, whatever he or she prefers. The committer can choose between committing two patches ony by one, or rebasing them to a single commit. I will avoid the "patch for the patch" practice from now on. Sorry for the inconvenience. -- Best regards, Aleksander Alekseev
Commits
-
Allow specifying STORAGE attribute for a new table
- 784cedda0604 16.0 landed