Re: pg_resetwal tests, logging, and docs update

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Peter Eisentraut <peter@eisentraut.org>

Date: 2023-09-26T15:19:23Z

Lists: pgsql-hackers

Hi,

> Hmm, I think I like "where" better.

OK.

> Attached is an updated patch set where I have split the changes into
> smaller pieces.  The last two patches still have some open questions
> about what certain constants mean etc.  The other patches should be settled.

The patches 0001..0005 seem to be ready and rather independent. I
suggest merging them and continue discussing the rest of the patches.

-- 
Best regards,
Aleksander Alekseev

Commits

doc: pg_resetwal: Add comments how the multipliers are derived
- 6ceec8a1fe7a 17.0 landed
pg_resetwal: Add more tests and test coverage
- 7b5275eec3a5 17.0 landed
More consistent behavior of GetDataDirectoryCreatePerm on Windows
- 2c7c6c417fe6 17.0 landed
doc: Improve documentation about pg_resetwal -f option
- 5f1b00e64aee 17.0 landed
pg_resetwal: Use frontend logging API
- a11d8e10f226 17.0 landed
pg_resetwal: Regroup --help output
- b5da1b3a939a 17.0 landed
pg_resetwal: Improve error with wrong/missing data directory
- 1d863c250461 17.0 landed
pg_resetwal: Update an obsolete comment
- 7273945cafa7 17.0 landed