Re: Remove unused fields in ReorderBufferTupleBuf
Aleksander Alekseev <aleksander@timescale.com>
From: Aleksander Alekseev <aleksander@timescale.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2023-07-26T13:52:14Z
Lists: pgsql-hackers
Attachments
- v3-0001-Remove-unused-fields-in-ReorderBufferTupleBuf.patch (application/octet-stream) patch v3-0001
- v3-0002-Replace-ReorderBufferTupleBufData-macro-with-a-fu.patch (application/octet-stream) patch v3-0002
Hi, > Here is the corrected patch. I added it to the nearest CF [1]. I played a bit more with the patch. There was an idea to make ReorderBufferTupleBufData an opaque structure known only within reorderbyffer.c but it turned out that replication/logical/decode.c accesses it directly so I abandoned that idea for now. > Alternatively we could convert ReorderBufferTupleBufData macro to an > inlined function. At least it will add some type safety. Here is v3 that implements it too as a separate patch. Apologies for the noise. -- Best regards, Aleksander Alekseev
Commits
-
Remove ReorderBufferTupleBuf structure.
- 08e6344fd642 17.0 landed
-
Generational memory allocator
- a4ccc1cef5a0 11.0 cited