Horton

Re: pg_resetwal tests, logging, and docs update

Aleksander Alekseev <aleksander@timescale.com>

View thread View on postgr.es
From: Aleksander Alekseev <aleksander@timescale.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter@eisentraut.org>
Date: 2023-11-01T11:12:30Z
Lists: pgsql-hackers

Attachments

Hi,

> Hmm.  I think maybe we should fix the behavior of
> GetDataDirectoryCreatePerm() to be more consistent between Windows and
> non-Windows.  This is usually the first function a program uses on the
> proposed data directory, so it's also responsible for reporting if the
> data directory does not exist.  But then on Windows, because the
> function does nothing, those error scenarios end up on quite different
> code paths, and I'm not sure if those are really checked that carefully.
>   I think we can make this more robust if we have
> GetDataDirectoryCreatePerm() still run the stat() call on the proposed
> data directory and report the error.  See attached patch.

Yep, that would be much better.

Attaching all three patches together in order to make sure cfbot is
still happy with them while the `master` branch is evolving.

Assuming cfbot will have no complaints I suggest merging them.

-- 
Best regards,
Aleksander Alekseev

Commits

  1. doc: pg_resetwal: Add comments how the multipliers are derived

  2. pg_resetwal: Add more tests and test coverage

  3. More consistent behavior of GetDataDirectoryCreatePerm on Windows

  4. doc: Improve documentation about pg_resetwal -f option

  5. pg_resetwal: Use frontend logging API

  6. pg_resetwal: Regroup --help output

  7. pg_resetwal: Improve error with wrong/missing data directory

  8. pg_resetwal: Update an obsolete comment