Horton

Re: Annoying build warnings from latest Apple toolchain

Aleksander Alekseev <aleksander@timescale.com>

View thread View on postgr.es
From: Aleksander Alekseev <aleksander@timescale.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Peter Eisentraut <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>
Date: 2023-11-21T15:41:35Z
Lists: pgsql-hackers 
Hi,

> > On Mon, Nov 20, 2023 at 11:37 PM Andres Freund <andres@anarazel.de> wrote:
> >> WRT Robert seeing those warnings and Tom not: There's something odd going
> >> on. I couldn't immediately reproduce it. Then I realized it reproduces against
> >> a homebrew install but not a macports one.
> >>
> >> Robert, which are you using?
> >
> > macports
>
> Btw., I'm also seeing warnings like this.  I'm using homebrew.  Here is
> a sample:
>
> [145/147] Linking target src/test/modules/test_shm_mq/test_shm_mq.dylib
> -macosx_version_min has been renamed to -macos_version_min
> ld: warning: -undefined error is deprecated
> ld: warning: ignoring duplicate libraries: '-lgcc'
> [146/147] Linking target src/test/modules/test_slru/test_slru.dylib

I prefer not to build Postgres on Mac because it slows down GMail and
Slack. After reading this discussion I tried and I can confirm I see
the same warnings Robert does:

```
[322/1905] Linking target src/interfaces/libpq/libpq.5.dylib
ld: warning: -undefined error is deprecated
ld: warning: ignoring duplicate libraries: '-lz'
[326/1905] Linking target src/timezone/zic
ld: warning: -undefined error is deprecated
ld: warning: ignoring duplicate libraries: '-lz'
[1113/1905] Linking target src/backend/postgres
ld: warning: -undefined error is deprecated
ld: warning: ignoring duplicate libraries: '-lpam', '-lxml2', '-lz'
[1124/1905] Linking target src/backend/replication/pgoutput/pgoutput.dylib
ld: warning: -undefined error is deprecated
[1125/1905] Linking target
src/backend/replication/libpqwalreceiver/libpqwalreceiver.dylib
ld: warning: -undefined error is deprecated

... many more ...
```

My laptop is an Intel MacBook Pro 2019. The MacOS version is Sonoma
14.0 and I'm using homebrew. `xcode-select --version` says 2399. I'm
using the following command:

```
XML_CATALOG_FILES=/usr/local/etc/xml/catalog time -p sh -c 'git clean
-dfx && meson setup --buildtype debug -DPG_TEST_EXTRA="kerberos ldap
ssl" -Dldap=disabled -Dssl=openssl -Dcassert=true -Dtap_tests=enabled
-Dprefix=/Users/eax/pginstall build && ninja -C build && ninja -C
build docs && meson test -C build'
```

I don't see any warnings when using Autotools.

--
Best regards,
Aleksander Alekseev

Commits

  1. meson: macos: Avoid warnings on Sonoma

  2. Restore proper linkage of pg_char_to_encoding() and friends.

  3. meson: macos: Correct -exported_symbols_list syntax for Sonoma compat

  4. Suppress macOS warnings about duplicate libraries in link commands.

  5. Stop using "-multiply_defined suppress" on macOS.

  6. Fix the inadvertent libpq ABI breakage discovered by Martin Pitt: the

  7. Cause libpq and ecpg libraries to be built as proper shared libraries