Re: [PATCH] Refactor pqformat.{c,h} and protocol.h

Aleksander Alekseev <aleksander@timescale.com>

From: Aleksander Alekseev <aleksander@timescale.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-07-16T19:58:37Z
Lists: pgsql-hackers
Hi,

> Thanks.  The only thing that stands out to me is the name of the parallel
> leader/worker protocol message.  In the original thread for protocol
> characters, some early versions of the patch called it a "parallel
> progress" message, but this new one just calls it PqMsg_Progress.  I guess
> PqMsg_ParallelProgress might be a tad more descriptive and less likely to
> cause naming collisions with new frontend/backend messages, but I'm not
> tremendously worried about either of those things.  Thoughts?

Personally I'm fine with either option.

-- 
Best regards,
Aleksander Alekseev



Commits

  1. Use PqMsg_* macros in more places.