Horton
Menu

Re: Typos in the code and README

Alexander Lakhin <exclusion@gmail.com>

View thread
From: Alexander Law <exclusion@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2026-01-05T19:00:00Z
Lists: pgsql-hackers 
Hello Andres,

On Mon, Jan 5, 2026, 21:24 Andres Freund <andres@anarazel.de> wrote:

>
> On 2026-01-01 10:00:00 +0200, Alexander Lakhin wrote:
> > bufhdr -> bufHdr
>
> I just ran into this one due to a rebase conflict. Obviously trivial to
> resolve. But what's the point of this change?  If you wanted to fix the
> arguably wrong name, it'd have to be "buf" or "BufferDesc", as there's no
> variable named either bufhdr or bufHdr.
>

I thought that the initial spelling was meant to reference bufHdr variable
as if it was declared locally as we can see this name in other functions in
bufmgr.c (at 5d508736).

The point was to have no references to entities that you can't find in the
source tree.


> Having random stuff mixed into these changes is one of the reasons why I so
> dislike them.
>

I'm not sure how to arrange such changes to process them efficiently --
they could be split to multiple "Fix a typo" patches, of course.

By the way, I've just noticed that I fixed only one out of two typos in
"parititoned", so it's still spelled wrong: "partititoned". Sorry.

Best regards,
Alexander

>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional