Horton

Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)"

Amit Khandekar <amitdkhan.pg@gmail.com>

View thread View on postgr.es
From: Amit Khandekar <amitdkhan.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, amul sul <sulamul@gmail.com>
Date: 2018-06-18T09:39:47Z
Lists: pgsql-hackers 
On 16 June 2018 at 19:30, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Sat, Jun 16, 2018 at 10:44 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> Yeah, or perhaps disallow creation of any partial paths at the first
>> place like in attached.   This will save us some work as well.
>>
>
> Attached patch contains test case as well.  I have tried to come up
> with some simple test, but couldn't come up with anything much simpler
> than reported by Rajkumar, so decided to use the test case provided by
> him.
>

Thanks for the patch. I had a look at it, and it looks good to me. One
minor comment :

+-- Parallel Append is not be used when the subpath depends on the outer param
"is not be used" => "is not to be used"

-- 
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company

Commits

  1. Improve coding pattern in Parallel Append code.

  2. Support Parallel Append plan nodes.