Re: UPDATE of partition key

Amit Khandekar <amitdkhan.pg@gmail.com>

From: Amit Khandekar <amitdkhan.pg@gmail.com>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

Cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2017-10-16T08:41:06Z

Lists: pgsql-hackers

Attachments

update-partition-key_v20_rebased.patch (application/octet-stream) patch v20

On 16 October 2017 at 08:28, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> Hi Amit.
>
> On 2017/10/04 22:51, Amit Khandekar wrote:
>> Main patch :
>> update-partition-key_v20.patch
>
> Guess you're already working on it but the patch needs a rebase.  A couple
> of hunks in the patch to execMain.c and nodeModifyTable.c fail.

Thanks for taking up this review Amit. Attached is the rebased
version. Will get back on your review comments and updated patch soon.

-- 
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company

Commits

Avoid referencing off the end of subplan_partition_offsets.
- 945f71db8452 11.0 landed
Allow UPDATE to move rows between partitions.
- 2f178441044b 11.0 landed
Remove useless lookup of root partitioned rel in ExecInitModifyTable().
- dca48d145e0e 11.0 cited
Factor error generation out of ExecPartitionCheck.
- 19c47e7c8202 11.0 landed
Minor preparatory refactoring for UPDATE row movement.
- ef6087ee5fa8 11.0 landed
Simplify and encapsulate tuple routing support code.
- cc6337d2fed5 11.0 landed
Avoid coercing a whole-row variable that is already coerced.
- 1c497fa72df7 11.0 landed
Use ResultRelInfo ** rather than ResultRelInfo * for tuple routing.
- 60f7c0abef03 11.0 landed
Make RelationGetPartitionDispatchInfo expand depth-first.
- 77b6b5e9ceca 11.0 cited
Expand partitioned tables in PartDesc order.
- 30833ba154e0 11.0 cited
Use a real RT index when setting up partition tuple routing.
- f81a91db4d1c 10.0 cited
Fix transition tables for partition/inheritance.
- 501ed02cf6f4 10.0 cited
Fix confusion about number of subplans in partitioned INSERT setup.
- 78a030a44196 10.0 cited
Prevent BEFORE triggers from violating partitioning constraints.
- 15ce775faa42 10.0 cited
Fire per-statement triggers on partitioned tables.
- e180c8aa8caf 10.0 cited
Fix reporting of violations in ExecConstraints, again.
- c0a8ae7be392 10.0 cited
Don't scan partitioned tables.
- d3cc37f1d801 10.0 cited
Allow FDWs to push down quals without breaking EvalPlanQual rechecks.
- 5fc4c26db512 9.6.0 cited