Thread

Commits

  1. Fix typo in pg_stat_us_to_ms()

  1. [Patch] Fix typo in pg_stat_us_to_ms()

    Tatsuya Kawata <kawatatatsuya0913@gmail.com> — 2026-07-02T13:36:01Z

    Hi,
    
    While reading pgstatfuncs.c, I noticed a small inconsistency in
    pg_stat_us_to_ms().
    
    The function converts microseconds to milliseconds, but the parameter
    is named val_ms, which suggests the opposite direction.
    
    Attached is a trivial patch renaming the parameter to val_us.
    
    Regards,
    Tatsuya Kawata
    
  2. Re: [Patch] Fix typo in pg_stat_us_to_ms()

    Michael Paquier <michael@paquier.xyz> — 2026-07-02T23:26:07Z

    On Thu, Jul 02, 2026 at 10:36:01PM +0900, Tatsuya Kawata wrote:
    > While reading pgstatfuncs.c, I noticed a small inconsistency in
    > pg_stat_us_to_ms().
    > 
    > The function converts microseconds to milliseconds, but the parameter
    > is named val_ms, which suggests the opposite direction.
    > 
    > Attached is a trivial patch renaming the parameter to val_us.
    
    Aha.  Fun.  Will fix, thanks.
    --
    Michael