Thread

Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE

Tatsuya Kawata <kawatatatsuya0913@gmail.com> — 2025-11-21T16:25:58Z

Hi Sawada-san,

Thank you for your additional feedback on v4!

>We can initialize dead_items_max_bytes when declared.
Thank you. I fixed it as you mentioned.

>Does it need to check if vacrel->dead_items is non-NULL?
Thank you. I fixed it as you mentioned.

>I think we should not use "index scans" since the number doesn't
>actually represent the number of index scans performed. How about
>something like:
>
>memory usage: 1.02 MB in total, with dead-item storage reset 15 times
>(limit was 0.06 MB)
>
>Also when it comes to the plural, we can use errmsg_plural() instead.
Thank you. I fixed the message as you mentioned.
Also, I found that ngettext() with appendStringInfo() is a standard pattern
in the PostgreSQL codebase (e.g., src/backend/catalog/pg_shdepend.c,
src/backend/catalog/dependency.c), so I use ngettext() in this code.

If it's good to use errmsg_plural(), I can restructure the code to use
errmsg_plural().

Best regards,
Tatsuya Kawata