Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
Tatsuya Kawata <kawatatatsuya0913@gmail.com>
From: Tatsuya Kawata <kawatatatsuya0913@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-12-30T03:23:24Z
Lists: pgsql-hackers
Attachments
- v11-0001-Add-dead-items-memory-usage-to-VACUUM-VERBOSE-an.patch (application/octet-stream)
Hi Sawada-san and Chao-san, Thank you both for your continued reviews and feedback on this patch.I agree with both points that could be misleading. I've updated the message as follows: memory usage: dead item storage %.2f MB accumulated across %d resets (limit %.2f MB each) This wording: - Use both "memory usage:" prefix and "dead item storage" to be consistent with other existing log lines (buffer usage:, WAL usage:, system usage:) and to clarify what kind of memory we're reporting - Clearly indicate that the value is a cumulative sum of snapshots, not actual memory allocation - Use "across %d resets" to show the relationship between the accumulated value and reset count - Keep "limit %.2f MB each" to indicate the per-reset memory limit Please find attached the v11 patch. Regards, Tatsuya Kawata