Horton

Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE

Tatsuya Kawata <kawatatatsuya0913@gmail.com>

View thread
From: Tatsuya Kawata <kawatatatsuya0913@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-12-23T13:20:08Z
Lists: pgsql-hackers

Attachments

Hi Sawada-san and Chao-san,

Thank you both for your continued reviews and feedback on this patch.

> The patch mostly looks good to me. I've made some cosmetic changes to
>   the comments  (as well as the commit message) and attached the updated
>   patch. Please review it.
Thank you. I have no objections.


> My last nitpick on v9:
>
>   ```
>   +                       appendStringInfo(&buf,
>   +
ngettext("memory usage: %.2f MB in total, with dead-item storage reset %d
time (limit was %.2f MB)\n",
>   +
   "memory usage: %.2f MB in total, with dead-item storage reset %d times
(limit was %.2f MB)\n",
>   ```
>
>   Instead of “dead-item”, I would suggest “dead item” (without dash),
because in the existing code use “dead item”, for example:
>
>   ```
I've addressed your feedback.

Attached is v10 with these changes incorporated.
I really appreciate reviewing this patch throughout the iterations.

Regards,
Tatsuya Kawata