Re: BUG #15940: json_populate_recordset fails with ERROR: record type has not been registered

Merlin Moncure <mmoncure@gmail.com>

From: Merlin Moncure <mmoncure@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dmitry Dolgov <9erthalion6@gmail.com>, yarexeray@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-08-09T12:59:31Z
Lists: pgsql-bugs
On Thu, Aug 8, 2019 at 9:35 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Aug 06, 2019 at 02:53:45PM -0500, Merlin Moncure wrote:
> > For posterity I agree that OP was essentially exploiting undefined, or
> > at least poorly defined, behavior.  For my money, I'd advise using
> > this function for cases where you don't want to use an in place type,
> > just a column list:
>
> If I were to change something here, that would be this error string
> exposed to the user.  With the current error, there is no real way
> that the user knows what is wrong and why he/she should not do that.
> Could it be possible to add some recommendation for example on top of
> an error "cannot do that because blah"?

Good question.  Maybe something like, "ERROR: Unable to expand generic
rowtype.  HINT: Try using explicit cast on rowtype"

merlin



Commits

  1. Restore json{b}_populate_record{set}'s ability to take type info from AS.

  2. Support domains over composite types.