Re: [patch] libpq one-row-at-a-time API
Merlin Moncure <mmoncure@gmail.com>
From: Merlin Moncure <mmoncure@gmail.com>
To: Marko Kreen <markokr@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Postgres Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-25T00:06:46Z
Lists: pgsql-hackers
On Tuesday, July 24, 2012, Marko Kreen <markokr@gmail.com> wrote: > On Wed, Jul 25, 2012 at 1:29 AM, Merlin Moncure <mmoncure@gmail.com> wrote: >> On Tue, Jul 24, 2012 at 4:59 PM, Marko Kreen <markokr@gmail.com> wrote: >>> So if we give only PQgetResult() in 9.2, I do not see that we >>> are locked out from any interesting optimizations. >> >> Well, you are locked out of having PQgetResult reuse the conn's result >> since that would then introduce potentially breaking changes to user >> code. > > You can specify special flags to PQsend or have special PQgetResultWeird() > calls to get PGresults with unusual behavior. Like I did with PQgetRowData(). > > I see no reason here to reject PQgetResult() that returns normal PGresult. Yeah -- I agree. So, given the scheduling, I think we should go with non-PQgetRowData patch and reserve optimized path for 9.3. merlin