Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

On Mon, Mar 10, 2025 at 11:04 AM Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Mon, Mar 10, 2025 at 3:58 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Thu, Mar 6, 2025 at 9:18 AM Ajin Cherian <itsajin@gmail.com> wrote:
> >
> > > +       Subscription names, publication names, and replication slot names are
> > > +       automatically generated. Cannot be used together with
> > > +       <option>--database</option>, <option>--publication</option>,
> > > +       <option>--replication-slot</option> or <option>--subscription</option>.
> > >
> > > Don't start the sentence with "Cannot". Change the sentence to "This
> > > option cannot be used together with ..."
> > > similar sentences used in 3 other places below this as well. Change all of them.
> >
> > I didn't find any instance of "Cannot be" in the *.sgml files, but I
> > find some instances of "Can be". So it seems we allow such constructs
> > in the documentation. Any reasons for suggesting this change?
> >
>
> I just don't think it is correct English to start a sentence with
> "Cannot be". I checked with grammarly as well.
>

Fixed.

The attached patch at [1] contains the required changes.

[1] - https://www.postgresql.org/message-id/CAHv8Rj%2B37ja589BzqB5bz0ZYGWb5gpnP9of8SoqKc%3DDqLmvxBg%40mail.gmail.com

Thanks and regards,
Shubham Khanna.