Horton
Menu

Re: Pgoutput not capturing the generated columns

Shubham Khanna <khannashubham1197@gmail.com>

View thread
From: Shubham Khanna <khannashubham1197@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>
Date: 2024-08-16T04:34:46Z
Lists: pgsql-hackers

Attachments

On Thu, Aug 8, 2024 at 12:43 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> I think the v25-0001 patch only half-fixes the problems reported in my
> v24-0001 review.
>
> ~
>
> Background (from the commit message):
> This commit enables support for the 'include_generated_columns' option
> in logical replication, allowing the transmission of generated column
> information and data alongside regular table changes.
>
> ~
>
> The broken TAP test scenario in question is replicating from a
> "not-generated" column to a "generated" column. As the generated
> column is not on the publishing side, IMO the
> 'include_generated_columns' option should have zero effect here.
>
> In other words, I expect this TAP test for 'include_generated_columns
> = true' case should also be failing, as I wrote already yesterday:
>
> +# FIXME
> +# Since there is no generated column on the publishing side this should give
> +# the same result as the previous test. -- e.g. something like:
> +# ERROR:  logical replication target relation
> "public.tab_nogen_to_gen" is missing
> +# replicated column: "b"

I have fixed the given comments. The attached v26-0001 Patch contains
the required changes.

Thanks and Regards,
Shubham Khanna.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.