Horton

Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.

Shubham Khanna <khannashubham1197@gmail.com>

View thread View on postgr.es
From: Shubham Khanna <khannashubham1197@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-17T18:45:57Z
Lists: pgsql-hackers

Attachments

On Mon, Feb 17, 2025 at 9:43 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 22 Jan 2025 at 16:23, Shubham Khanna
> <khannashubham1197@gmail.com> wrote:
> >
> > Hi,
> >
> > Following the recent comments on Patch v13-0001, the patch was not
> > applied to the HEAD. I have addressed the feedback and prepared a
> > rebased version to incorporate the necessary adjustments.
> > Please find the updated patch.
>
> The patch needs to be rebased:
> git am v14-0001-Add-support-for-two-phase-commit-in-pg_createsub.patch
> Applying: Add support for two-phase commit in pg_createsubscriber
> error: patch failed: src/bin/pg_basebackup/pg_createsubscriber.c:1326
> error: src/bin/pg_basebackup/pg_createsubscriber.c: patch does not apply
>

I have addressed the feedback and prepared a rebased version to
incorporate the necessary adjustments.
Please find the updated patch.

Thanks and regards,
Shubham Khanna.

Commits

  1. Add two-phase option in pg_createsubscriber.