Horton

Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.

Shubham Khanna <khannashubham1197@gmail.com>

View thread View on postgr.es
From: Shubham Khanna <khannashubham1197@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-20T07:00:26Z
Lists: pgsql-hackers 
On Mon, Jan 20, 2025 at 12:00 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> Patch v12-0001 LGTM.
>
> BTW, there is a precedent for passing the 'opt' arg but then only
> using one member from it. See function wait_for_end_recovery in this
> same file. So whether you decide to change the code per Shlok's review
> [1], or decide not to change it -- either way is OK for me.
>
> ======
> [1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com
>

I have incorporated Shlok's suggestion [1] into the patch and made the
necessary updates.
The attached v13 patch at [2] contains the updated changes.

[1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAHv8RjJfaHFMeDkHOdMpLUHCeDN%2Be5p0CsdQxcKEOiWRnRjxfg%40mail.gmail.com

Thanks and regards,
Shubham Khanna.

Commits

  1. Add two-phase option in pg_createsubscriber.