Re: pg_createsubscriber: publication-name and subscription-name options do not exist

On Tue, Dec 3, 2024 at 10:25 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> The patch v5-0001 looks mostly OK to me (visual inspection only).
>
> But, I did notice one other improvement you could make in passing.
>
> 1.
> -      TABLES</literal></link>.  If <option>publication-name</option> option is
> -      not specified, it has the following name pattern:
> +      TABLES</literal></link>.  If <option>--publication</option> is not
> +      specified, it has the following name pattern:
>
> Instead of saying "it has the following name pattern:", IMO it is better to say:
> "the publication has the following name pattern:".
>
> That would make it consistent with the similar sentences which are saying:
> "... the replication slot has the following name pattern:
> "... the subscription has the following name pattern:"
>

I have added the suggested change. The attached Patch contains the
required changes.

Thanks and regards,
Shubham Khanna.