Re: pg_createsubscriber: publication-name and subscription-name options do not exist

On Mon, Dec 2, 2024 at 4:57 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 2 Dec 2024 at 15:00, Shubham Khanna <khannashubham1197@gmail.com> wrote:
> >
> > On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
> > <noreply@postgresql.org> wrote:
> > >
> > > The following documentation comment has been logged on the website:
> > >
> > > Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > > Description:
> > >
> > > The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > > mentions these two options:
> > > “If publication-name option is not specified …“
> > > “If subscription-name is not specified …“
> > >
> > > while `pg_createsubscriber --help` returns:
> > >
> > >       --publication=NAME          publication name
> > >       --replication-slot=NAME     replication slot name
> > >       --subscription=NAME         subscription name
> > >
> > > I suppose that the options should be respectively --publication and
> > > --subscription.
> > >
> >
> > I have updated the Documentation for pg_createsubscriber with the
> > suggested changes. The attached Patch contains the required changes.
>
> Thanks for the patch, one suggestion:
> We can change "<option>subscription</option>" to
> "<option>subscription</option> option" to keep it consistent with
> publication option documentation just above a few lines which mentions
> it like "If <option>publication</option> option is not specified":
>        Create a subscription for each specified database on the target server.
> -      If <option>subscription-name</option> is not specified, the subscription
> +      If <option>subscription</option> is not specified, the subscription
>        has the following name pattern:
>        <quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
>

I have fixed the suggested changes. The attached Patch contains the
required changes.

Thanks and regards,
Shubham Khanna.