Horton

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Timur Magomedov <t.magomedov@postgrespro.ru>
Cc: Tomas Vondra <tomas@vondra.me>, "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-06-19T05:08:04Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Mark ItemPointer arguments as const throughout

  2. Reorganize GUC structs

  3. Eliminate XLOG_HEAP2_VISIBLE from vacuum phase III

  4. Update various forward declarations to use typedef

  5. Pathify RHS unique-ification for semijoin planning

  6. Revert "Don't lock partitions pruned by initial pruning"

  7. For inplace update, send nontransactional invalidations.

  8. Remove nearly-unused SizeOfIptrData macro.

On Tue, Jun 10, 2025 at 6:02 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Timur.
>
> On Wed, Jun 4, 2025 at 11:47 PM Timur Magomedov
> <t.magomedov@postgrespro.ru> wrote:
> >
> > Hello Peter,
> >
> > I've tried running VCI, the idea looks great to me. Thank you and
> > Iwata-san for working on this feature. Looked at the source code of VCI
> > module, the patch is huge but here are some ideas I hope could be
> > useful for community. Made some patches on top of v4 that can be
> > squashed into future iteration of VCI module.
> >
> > 0001-Removed-unnecessary-preload-libraries-checks.patch
> > Please correct me if I'm wrong but there is no need for adding VCI to
> > "session_preload_libraries" in case it is in "shared_preload_libraries"
> > already.
>
> I think you are correct, but I am still checking the history of this
> code before making this change.
>

Hi Timur.

Done. This is applied in the latest v8-0002.

FYI, there was some reason for requiring both parameters to be set,
related to issues when using vci in single-user mode. However, being
such a niche problem, it was judged better to remove such code
complications from the current patch 0002; we can revisit this in
future if necessary.

======
Kind Regards,
Peter Smith.
Fujitsu Australia