Horton
Menu

Re: StringInfo fixes, v19 edition. Plus a few oddities

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2026-04-28T05:46:34Z
Lists: pgsql-hackers 
Hi Vignesh.

Feedback for v4-0001.

======
src/backend/replication/logical/conflict.c

I guess the following are not strictly the fault of this patch, but I
thought a few of these messages could be improved and made consistent.
Since you are anyway changing most of these messages, now might be the
best time to do it.

e.g.
Current: "Updating the row that was..."

SUGGESTION#1. "Updating a row that was..."
SUGGESTION#2. "Attempting to update a row that was..."
SUGGESTION#3. "The row to be updated was..."

e.g.
Current: "Deleting the row that was..."

SUGGESTION#1. "Deleting a row that was..."
SUGGESTION#2. "Attempting to delete a row that was..."
SUGGESTION#3. "The row to be deleted was..."

~~

And another below (outside the patch) could be updated to be the same:

e.g.
Current: "The row to be updated was deleted by..."

SUGGESTION#1. "Updating a row that was deleted by..."
SUGGESTION#2. "Attempting to update a row that was deleted by..."
SUGGESTION#3. Leave as-is. "The row to be updated was..."

~~~

All those conflict messages should be consistent-looking.

I prefer suggestion #3 because those are also the same as the existing
code comments of the ConflictType enum.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Simplify translatable messages for tuple value details in conflict.c.

  2. Improve various new-to-v19 appendStringInfo calls