Horton

Re: Typo in tablesync comment

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-03T07:52:56Z
Lists: pgsql-hackers 
On Wed, Feb 3, 2021 at 6:13 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Feb 02, 2021 at 07:23:37PM +0530, Amit Kapila wrote:
> > I don't mind changing to your proposed text but I think the current
> > wording is also okay and seems clear to me.
>
> Reading that again, I still find the word "transient" to be misleading
> in this context.  Any extra opinions?

OTOH I thought "additionally stored" made it seem like those states
were in the catalog and "additionally" in shared memory.

Maybe better to rewrite it more drastically?

e.g
-----
 *    The catalog pg_subscription_rel is used to keep information about
 *    subscribed tables and their state. The catalog holds all states
 *    except SYNCWAIT and CATCHUP which are only in shared memory.
-----

Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Clarify comment in tablesync.c