Re: Pgoutput not capturing the generated columns

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Shubham Khanna <khannashubham1197@gmail.com>

Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>

Date: 2024-08-08T07:13:15Z

Lists: pgsql-hackers

Hi Shubham,

I think the v25-0001 patch only half-fixes the problems reported in my
v24-0001 review.

~

Background (from the commit message):
This commit enables support for the 'include_generated_columns' option
in logical replication, allowing the transmission of generated column
information and data alongside regular table changes.

~

The broken TAP test scenario in question is replicating from a
"not-generated" column to a "generated" column. As the generated
column is not on the publishing side, IMO the
'include_generated_columns' option should have zero effect here.

In other words, I expect this TAP test for 'include_generated_columns
= true' case should also be failing, as I wrote already yesterday:

+# FIXME
+# Since there is no generated column on the publishing side this should give
+# the same result as the previous test. -- e.g. something like:
+# ERROR:  logical replication target relation
"public.tab_nogen_to_gen" is missing
+# replicated column: "b"

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Generated column replication.
- 6252b1eaf82b 18.0 landed
Rename pubgencols_type to pubgencols in pg_publication.
- 75eb9766ec20 18.0 landed
Doc: Fix column name in pg_publication catalog.
- 117f9f328e0f 18.0 landed
Fix buildfarm failure introduced by commit e65dbc9927.
- b35434b134b1 18.0 landed
Change publication's publish_generated_columns option type to enum.
- e65dbc9927fb 18.0 landed
Fix \dRp+ output when describing publications with a lower server version.
- 991974bb4888 18.0 landed
Replicate generated columns when 'publish_generated_columns' is set.
- 7054186c4ebe 18.0 landed
Doc: Update the behavior of generated columns in Logical Replication.
- 5b0c46ea0932 18.0 landed
Replicate generated columns when specified in the column list.
- 745217a051a9 18.0 landed
Doc: Generated columns are skipped for logical replication.
- 7a089f6e6a14 17.0 cited