Thread

Commits

  1. doc: Fix sentence of pg_walsummary page

  1. DOCS - pg_walsummary typo?

    Peter Smith <smithpb2250@gmail.com> — 2026-02-16T03:39:29Z

    Hi.
    
    I found what seems to be a typo in the pg_walsummary description. I
    guess that "with" was supposed to say "within", but IMO just "in" is
    fine.
    
    BEFORE
    These binary files are found with the pg_wal/summaries subdirectory of
    the data directory...
    
    SUGGESTION
    These binary files are found in the pg_wal/summaries subdirectory of
    the data directory...
    
    
    PSA patch for the same.
    
    ======
    Kind Regards,
    Peter Smith.
    Fujitsu Australia.
    
  2. Re: DOCS - pg_walsummary typo?

    Robert Treat <rob@xzilla.net> — 2026-02-16T13:13:26Z

    On Sun, Feb 15, 2026 at 10:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
    >
    > Hi.
    >
    > I found what seems to be a typo in the pg_walsummary description. I
    > guess that "with" was supposed to say "within", but IMO just "in" is
    > fine.
    >
    > BEFORE
    > These binary files are found with the pg_wal/summaries subdirectory of
    > the data directory...
    >
    > SUGGESTION
    > These binary files are found in the pg_wal/summaries subdirectory of
    > the data directory...
    >
    >
    > PSA patch for the same.
    
    +1
    
    Robert Treat
    https://xzilla.net
    
    
    
    
  3. Re: DOCS - pg_walsummary typo?

    Chao Li <li.evan.chao@gmail.com> — 2026-02-24T03:11:08Z

    
    > On Feb 16, 2026, at 11:39, Peter Smith <smithpb2250@gmail.com> wrote:
    > 
    > Hi.
    > 
    > I found what seems to be a typo in the pg_walsummary description. I
    > guess that "with" was supposed to say "within", but IMO just "in" is
    > fine.
    > 
    > BEFORE
    > These binary files are found with the pg_wal/summaries subdirectory of
    > the data directory...
    > 
    > SUGGESTION
    > These binary files are found in the pg_wal/summaries subdirectory of
    > the data directory...
    > 
    > 
    > PSA patch for the same.
    > 
    > ======
    > Kind Regards,
    > Peter Smith.
    > Fujitsu Australia.
    > <v1-0001-DOCS-pg_walsummary-fix-typo.patch>
    
    I would guess “with” was a typo of “within”. I agree with changing “with” to “in”, alternatively, “within” and “under” may also work there.
    
    Best regards,
    --
    Chao Li (Evan)
    HighGo Software Co., Ltd.
    https://www.highgo.com/
    
    
    
    
    
    
    
    
  4. Re: DOCS - pg_walsummary typo?

    Michael Paquier <michael@paquier.xyz> — 2026-03-02T07:17:23Z

    On Mon, Feb 16, 2026 at 08:13:26AM -0500, Robert Treat wrote:
    > On Sun, Feb 15, 2026 at 10:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
    >> I found what seems to be a typo in the pg_walsummary description. I
    >> guess that "with" was supposed to say "within", but IMO just "in" is
    >> fine.
    >
    > +1
    
    Yep, the wording seems strange and switching this single word is an
    improvement.  Will fix later, if there are no objections.
    --
    Michael
    
  5. Re: DOCS - pg_walsummary typo?

    Michael Paquier <michael@paquier.xyz> — 2026-03-03T06:36:02Z

    On Mon, Mar 02, 2026 at 04:17:23PM +0900, Michael Paquier wrote:
    > Yep, the wording seems strange and switching this single word is an
    > improvement.  Will fix later, if there are no objections.
    
    Done.
    --
    Michael
    
  6. Re: DOCS - pg_walsummary typo?

    Peter Smith <smithpb2250@gmail.com> — 2026-03-09T03:01:44Z

    Thanks for pushing!
    
    I have marked the corresponding CF entry as "Committed".
    
    ======
    Kind Regards,
    Peter Smith.
    Fujitsu Australia.