Re: Allow logical replication to copy tables in binary format

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Melih Mutlu <m.melihmutlu@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Euler Taveira <euler@eulerto.com>, "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>

Date: 2023-03-14T00:48:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow logical replication to copy tables in binary format.
- ecb696527c01 16.0 landed
Common function for percent placeholder replacement
- c96de2ce1782 16.0 cited
Doc: add XML ID attributes to <sectN> and <varlistentry> tags.
- 78ee60ed84bb 16.0 cited
Re-order disable_on_error in tab-complete.
- d547f7cf5efc 16.0 cited
Make subscription tests pass with log_error_verbosity=verbose
- 19408aae7fa2 15.0 cited
Weaken type-OID-matching checks in array_recv and record_recv.
- 670c0a1d474b 14.0 cited
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 cited

On Tue, Mar 14, 2023 at 11:06 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are some review comments for patch v12-0001
>
> ======
> General
>
> 1.
> There is no new test code. Are we sure that there are already
> sufficient TAP tests doing binary testing with/without copy_data and
> covering all the necessary combinations?
>

Oops. Please ignore this comment. Somehow I missed seeing those
032_binary_copy.pl tests earlier.

------
Kind Regards,
Peter Smith.
Fujitsu Australia